INNOCENT-BOY commented on code in PR #8314:
URL: https://github.com/apache/pinot/pull/8314#discussion_r841550355
##########
pinot-core/src/main/java/org/apache/pinot/server/access/BasicAuthAccessFactory.java:
##########
@@ -37,10 +40,16 @@
private AccessControl _accessControl;
+ @Override
public void init(PinotConfiguration configuration) {
- _accessControl = new
BasicAuthAccessControl(BasicAuthUtils.extractBasicAuthPrincipals(configuration,
PREFIX));
+// _accessControl = new
BasicAuthAccessControl(BasicAuthUtils.extractBasicAuthPrincipals(configuration,
PREFIX));
}
+ public void init(ZkHelixPropertyStore<ZNRecord> propertyStore) {
+ _accessControl = new BasicAuthAccessControl(new UserCache(propertyStore));
+ }
Review Comment:
I have extended the interface and default to legacy behavior. And move the
implementation to its class. Please check it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
