walterddr commented on code in PR #8484:
URL: https://github.com/apache/pinot/pull/8484#discussion_r849751887
##########
pinot-common/src/main/java/org/apache/pinot/sql/parsers/CalciteSqlParser.java:
##########
@@ -73,18 +74,6 @@ private CalciteSqlParser() {
public static final List<QueryRewriter> QUERY_REWRITERS = new
ArrayList<>(QueryRewriterFactory.getQueryRewriters());
private static final Logger LOGGER =
LoggerFactory.getLogger(CalciteSqlParser.class);
- /** Lexical policy similar to MySQL with ANSI_QUOTES option enabled. (To be
- * precise: MySQL on Windows; MySQL on Linux uses case-sensitive matching,
- * like the Linux file system.) The case of identifiers is preserved whether
- * or not they quoted; after which, identifiers are matched
- * case-insensitively. Double quotes allow identifiers to contain
- * non-alphanumeric characters. */
- private static final Lex PINOT_LEX = Lex.MYSQL_ANSI;
Review Comment:
yes they are. If you check the config impl behind the scene it uses the LEX
enum to see a whole bunch of settings I did here as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
