saurabhd336 commented on PR #8563: URL: https://github.com/apache/pinot/pull/8563#issuecomment-1108178120
@richardstartin @Jackie-Jiang @KKcorps @npawar This PR adds support of "and" and "or" conjugates via varargs function. As described in @richardstartin's review comment, this prohibits early termination and forces all conditions to be evaluated before and / or can be applied on their results. I've tried to address that here https://github.com/apache/pinot/pull/8582, modelling the conjugations a little differently. Suggest to review that PR instead. If that PR seems alright conceptually, I'll close this one and continue on that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
