sajjad-moradi commented on PR #8587: URL: https://github.com/apache/pinot/pull/8587#issuecomment-1111382267
> > @kmozaid This is being done as part of opening up upload endpoint for realtime segments - in this PR: #8584 > > ohk, then I can close this PR, right? Also I don't see the below change in `RealtimeTableDataManager` , How Server is going to handle `REFRESH_SEGMENT` message sent by controller when segment is uploaded? Did you verify that segment uploaded are queryable in your code? > Yes you can close this PR. Also good catch on segment refresh message handling on server side. In the integration test that I modified to upload realtime segments, I considered the refresh use case and modified the CRC of the existing segment on ZK for it, but in servers, the CRC remains the same on the local file and the segment refresh path doesn't get to the point to actually download the segment - it uses the existing segment since the CRC of the uploaded segment and the one residing on server are the same. I'll make the changes and try to update the integration test to change the CRC of the local file on server side. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
