INNOCENT-BOY commented on code in PR #8314:
URL: https://github.com/apache/pinot/pull/8314#discussion_r860382803
##########
pinot-broker/src/main/java/org/apache/pinot/broker/broker/AccessControlFactory.java:
##########
@@ -28,11 +30,24 @@ public abstract class AccessControlFactory {
public static final Logger LOGGER =
LoggerFactory.getLogger(AccessControlFactory.class);
public static final String ACCESS_CONTROL_CLASS_CONFIG = "class";
- public abstract void init(PinotConfiguration confguration);
+ public void init(PinotConfiguration configuration) {
+ };
+
+ /**
+ * Extend original init method inorder to support Zookeeper
BasicAuthAccessControlFactory
Review Comment:
@mayankshriv Sorry, I don't get your point. In my design, the reason why I
pass ZkHelixProperStore or something familiar parameters is just used to init
class AccessControlUserCache to keep track of user config other than get some
cluster properties.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
