deemoliu commented on code in PR #8355:
URL: https://github.com/apache/pinot/pull/8355#discussion_r861332495
##########
pinot-spi/src/main/java/org/apache/pinot/spi/utils/builder/ControllerRequestURLBuilder.java:
##########
@@ -194,7 +194,7 @@ public String forTableRebalance(String tableName, String
tableType, boolean dryR
}
public String forTableReload(String tableName, TableType tableType, boolean
forceDownload) {
- String query = String.format("reload?type=%s&forceDownload=%s",
tableType.name(), forceDownload);
+ String query = String.format("reload?forceDownload=%s&type=%s",
forceDownload, tableType.name());
Review Comment:
thanks for pointing out. reverted.
##########
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/Constants.java:
##########
@@ -46,6 +46,7 @@ private Constants() {
public static final String ZOOKEEPER = "Zookeeper";
public static final String APP_CONFIGS = "AppConfigs";
public static final String PERIODIC_TASK_TAG = "PeriodicTask";
+ public static final String UPSERT_RESOURCE_TAG = "UpsertResource";
Review Comment:
gotcha, updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
