walterddr commented on code in PR #8314:
URL: https://github.com/apache/pinot/pull/8314#discussion_r863222689
##########
pinot-core/src/main/java/org/apache/pinot/core/auth/BasicAuthUtils.java:
##########
@@ -61,21 +64,43 @@ private BasicAuthUtils() {
* @return list of BasicAuthPrincipals
*/
public static List<BasicAuthPrincipal>
extractBasicAuthPrincipals(PinotConfiguration configuration, String prefix) {
- String principalNames = configuration.getProperty(prefix);
- Preconditions.checkArgument(StringUtils.isNotBlank(principalNames), "must
provide principals");
+ String principalNames = configuration.getProperty(prefix);
+ Preconditions.checkArgument(StringUtils.isNotBlank(principalNames),
"must provide principals");
- return Arrays.stream(principalNames.split(",")).map(rawName -> {
- String name = rawName.trim();
- Preconditions.checkArgument(StringUtils.isNotBlank(name), "%s is not a
valid name", name);
+ return Arrays.stream(principalNames.split(",")).map(rawName -> {
+ String name = rawName.trim();
+ Preconditions.checkArgument(StringUtils.isNotBlank(name), "%s is not
a valid name", name);
- String password = configuration.getProperty(String.format("%s.%s.%s",
prefix, name, PASSWORD));
- Preconditions.checkArgument(StringUtils.isNotBlank(password), "must
provide a password for %s", name);
+ String password =
configuration.getProperty(String.format("%s.%s.%s", prefix, name, PASSWORD));
+ Preconditions.checkArgument(StringUtils.isNotBlank(password), "must
provide a password for %s", name);
- Set<String> tables = extractSet(configuration, String.format("%s.%s.%s",
prefix, name, TABLES));
- Set<String> permissions = extractSet(configuration,
String.format("%s.%s.%s", prefix, name, PERMISSIONS));
+ Set<String> tables = extractSet(configuration,
String.format("%s.%s.%s", prefix, name, TABLES));
+ Set<String> permissions = extractSet(configuration,
String.format("%s.%s.%s", prefix, name, PERMISSIONS));
- return new BasicAuthPrincipal(name, toBasicAuthToken(name, password),
tables, permissions);
- }).collect(Collectors.toList());
+ return new BasicAuthPrincipal(name, toBasicAuthToken(name,
password), tables, permissions);
+ }).collect(Collectors.toList());
+ }
+
+ public static List<ZkBasicAuthPrincipal>
extractBasicAuthPrincipals(List<UserConfig> userConfigList) {
+ return userConfigList.stream()
+ .map(user -> {
+ String name = user.getUserName().trim();
+ Preconditions.checkArgument(StringUtils.isNotBlank(name), "%s is not
a valid username", name);
+ String password = user.getPassword().trim();
Review Comment:
why do we need to trim password? is whitespace char not allowed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
