Jackie-Jiang commented on issue #8641: URL: https://github.com/apache/pinot/issues/8641#issuecomment-1121463021
@kkrugler Good question. I also found that override is not properly handled when it is not allowed. Currently we only log a warning and continue. We may support both behaviors using a `terminateOnFailure` flag: 1. If it is not set (default), we should track all the failed segment and continue. We shouldn't need to clean up the file in the `outputSegmentTarURI` because copy is the last step of the segment creation. In the end, fail the task with all the failed segments returned but keep the already generated one 2. If it is set, we should terminate immediately and clean up all the files already copied to the `outputSegmentTarURI` wdyt? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
