siddharthteotia commented on code in PR #8683:
URL: https://github.com/apache/pinot/pull/8683#discussion_r870635204
##########
pinot-spi/src/main/java/org/apache/pinot/spi/trace/InvocationRecording.java:
##########
@@ -28,6 +28,15 @@
*/
public interface InvocationRecording {
+ /**
+ * Sets the upper bound for the number of groups in a group by evaluation,
along with the actual number of groups.
+ * The ratio of these two quantities indicates how efficient the group by
was, and if truncation has occurred.
Review Comment:
Do we want to record something similar at the combine level as well ? There
we have trimToSize and trimThreshold and may have spent time in resizing (map
to PQ conversion and back) etc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
