Jackie-Jiang opened a new pull request, #8685: URL: https://github.com/apache/pinot/pull/8685
Caught by #8616 There are 2 race conditions on the time boundary handling in the broker request: - We read time boundary info twice, once for the offline request and once for the realtime request. If it gets updated between these 2 reads, we might attach filter of different value to the offline and realtime request, and get wrong result (less than expected). - The time boundary info is available when the first segment is pushed to the offline table. If we cannot find the time boundary, currently we don't attach the time filter. If the segment becomes online after attaching the time filter but before reading the routing table, we will query both offline and realtime table without the time filter and get wrong result (more than expected) Fix: - Read time boundary info once, and use it to attach time filter for both offline and realtime request - If time boundary info is not available, do not query the offline side -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
