Jackie-Jiang commented on code in PR #8687:
URL: https://github.com/apache/pinot/pull/8687#discussion_r871652667
##########
pinot-core/src/main/java/org/apache/pinot/core/startree/StarTreeUtils.java:
##########
@@ -94,13 +94,13 @@ public static AggregationFunctionColumnPair[]
extractAggregationFunctionPairs(
*/
@Nullable
public static Map<String, List<CompositePredicateEvaluator>>
extractPredicateEvaluatorsMap(IndexSegment indexSegment,
- @Nullable FilterContext filter, Map<Predicate, PredicateEvaluator>
predicateEvaluatorMap) {
+ @Nullable FilterContext filter, List<Pair<Predicate,
PredicateEvaluator>> predicateEvaluatorMap) {
Review Comment:
```suggestion
@Nullable FilterContext filter, List<Pair<Predicate,
PredicateEvaluator>> predicateEvaluators) {
```
##########
pinot-core/src/main/java/org/apache/pinot/core/startree/StarTreeUtils.java:
##########
@@ -187,7 +187,7 @@ public static boolean isFitForStarTree(StarTreeV2Metadata
starTreeV2Metadata,
*/
@Nullable
private static Pair<String, List<PredicateEvaluator>>
isOrClauseValidForStarTree(IndexSegment indexSegment,
- FilterContext filter, Map<Predicate, PredicateEvaluator>
predicateEvaluatorMap) {
+ FilterContext filter, List<Pair<Predicate, PredicateEvaluator>>
predicateEvaluatorMap) {
Review Comment:
```suggestion
FilterContext filter, List<Pair<Predicate, PredicateEvaluator>>
predicateEvaluators) {
```
##########
pinot-core/src/main/java/org/apache/pinot/core/plan/FilterPlanNode.java:
##########
@@ -68,7 +67,7 @@ public class FilterPlanNode implements PlanNode {
private final FilterContext _filter;
// Cache the predicate evaluators
- private final Map<Predicate, PredicateEvaluator> _predicateEvaluatorMap =
new HashMap<>();
+ private final List<Pair<Predicate, PredicateEvaluator>>
_predicateEvaluatorMap = new ArrayList<>();
Review Comment:
```suggestion
private final List<Pair<Predicate, PredicateEvaluator>>
_predicateEvaluators = new ArrayList<>();
```
##########
pinot-core/src/main/java/org/apache/pinot/core/plan/FilterPlanNode.java:
##########
@@ -108,7 +107,7 @@ public BaseFilterOperator run() {
/**
* Returns a map from predicates to their evaluators.
Review Comment:
Update the comment
##########
pinot-core/src/main/java/org/apache/pinot/core/startree/StarTreeUtils.java:
##########
@@ -258,7 +258,7 @@ private static boolean
extractOrClausePredicates(FilterContext filter, List<Pred
*/
@Nullable
private static PredicateEvaluator getPredicateEvaluator(IndexSegment
indexSegment, Predicate predicate,
- Map<Predicate, PredicateEvaluator> predicateEvaluatorMap) {
+ List<Pair<Predicate, PredicateEvaluator>> predicatesAndEvaluators) {
Review Comment:
(nit) for consistency
```suggestion
List<Pair<Predicate, PredicateEvaluator>> predicateEvaluators) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
