Jackie-Jiang commented on code in PR #8693:
URL: https://github.com/apache/pinot/pull/8693#discussion_r871924561
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/utils/SegmentPushUtils.java:
##########
@@ -88,7 +88,8 @@ public static URI generateSegmentTarURI(URI dirURI, URI
fileURI, String prefix,
return fileURI;
}
}
- return URI.create(String.format("%s%s%s", prefix, fileURI.getRawPath(),
suffix));
+ return URI.create(
+ String.format("%s%s%s", (prefix != null) ? prefix : "",
fileURI.getRawPath(), (suffix != null) ? suffix : ""));
Review Comment:
Might be more readable
```suggestion
(prefix != null ? prefix : "") + fileURI.getRawPath() + (suffix !=
null ? suffix : "");
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
