siddharthteotia commented on code in PR #8694: URL: https://github.com/apache/pinot/pull/8694#discussion_r871987948
########## pinot-server/src/main/java/org/apache/pinot/server/starter/helix/HelixInstanceDataManagerConfig.java: ########## @@ -74,6 +74,13 @@ public class HelixInstanceDataManagerConfig implements InstanceDataManagerConfig private static final String MAX_PARALLEL_SEGMENT_BUILDS = "realtime.max.parallel.segment.builds"; private static final int DEFAULT_MAX_PARALLEL_SEGMENT_BUILDS = 4; + // Key of how many parallel segment downloads can be made per table. + // A value of <= 0 indicates unlimited. + // Unlimited parallel downloads can make Pinot controllers receive high burst of download requests, + // causing controllers unavailable for that period of time. + private static final String MAX_PARALLEL_SEGMENT_DOWNLOADS = "table.level.max.parallel.segment.downloads"; + private static final int DEFAULT_MAX_PARALLEL_SEGMENT_DOWNLOADS = 4; Review Comment: let's keep the default behavior as is and instead internally configure what we need ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
