jackjlli commented on code in PR #8695:
URL: https://github.com/apache/pinot/pull/8695#discussion_r874023654
##########
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotSegmentUploadDownloadRestletResource.java:
##########
@@ -253,67 +284,70 @@ private SuccessResponse uploadSegment(@Nullable String
tableName, TableType tabl
// Fetch table name. Try to derive the table name from the parameter and
then from segment metadata
String rawTableName;
- if (tableName != null && !tableName.isEmpty()) {
+ if (StringUtils.isNotEmpty(tableName)) {
rawTableName = TableNameBuilder.extractRawTableName(tableName);
- LOGGER.info("Uploading a segment {} to table: {}, push type {},
(Derived from API parameter)", segmentName,
- tableName, uploadType);
} else {
// TODO: remove this when we completely deprecate the table name from
segment metadata
rawTableName = segmentMetadata.getTableName();
- LOGGER.info("Uploading a segment {} to table: {}, push type {},
(Derived from segment metadata)", segmentName,
- tableName, uploadType);
+ LOGGER.warn("Table name is not provided when uploading segment: {} for
table: {}", segmentName, rawTableName);
Review Comment:
Make it more explicit like:
`Table name is not provided when uploading segment: {} for table: {} from
segment metadata"`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
