Jackie-Jiang commented on code in PR #8711:
URL: https://github.com/apache/pinot/pull/8711#discussion_r874101509
##########
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java:
##########
@@ -133,7 +133,7 @@ public BaseBrokerRequestHandler(PinotConfiguration config,
BrokerRoutingManager
_queryQuotaManager = queryQuotaManager;
_tableCache = tableCache;
_brokerMetrics = brokerMetrics;
- _disableGroovy =
_config.getProperty(CommonConstants.Broker.DISABLE_GROOVY, false);
+ _disableGroovy =
_config.getProperty(CommonConstants.Broker.DISABLE_GROOVY, true);
Review Comment:
Suggest adding a constant for `DEFAULT_DISABLE_GROOVY`
##########
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java:
##########
@@ -1033,8 +1033,8 @@ private HandlerContext getHandlerContext(@Nullable
TableConfig offlineTableConfi
}
}
- // Disable Groovy if either offline or realtime table config disables
Groovy
- boolean disableGroovy = offlineTableDisableGroovyQuery |
realtimeTableDisableGroovyQuery;
+ // Disable Groovy if both offline and realtime table config disable Groovy
Review Comment:
Why do we change this? We can only allow groovy when both offline and
realtime table has it enabled
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
