xiangfu0 commented on code in PR #8560: URL: https://github.com/apache/pinot/pull/8560#discussion_r876295301
########## pinot-plugins/pinot-batch-ingestion/pinot-batch-ingestion-spark-3.2/src/main/java/org/apache/pinot/plugin/ingestion/batch/spark/SparkSegmentGenerationJobRunner.java: ########## @@ -0,0 +1,408 @@ +/** Review Comment: Will there be a problem when both spark 2.4 and 3.2 jars are presented with the same package and class name? Or do you intend to do this for one job spec file working for both? ########## pinot-plugins/pinot-batch-ingestion/pinot-batch-ingestion-spark-3.2/src/main/java/org/apache/pinot/plugin/ingestion/batch/spark/SparkSegmentGenerationJobRunner.java: ########## @@ -0,0 +1,408 @@ +/** Review Comment: Will there be a problem when both spark 2.4 and 3.2 jars are presented with the same package and class name? Or do you intend to do this so the same job spec file working for both? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
