npawar commented on PR #8740:
URL: https://github.com/apache/pinot/pull/8740#issuecomment-1132365708
> > If I read the code correctly, right now the idle time period is fixed 3
minutes. We can just make that configurable
>
> If I understood it correctly, it can changes based on fetchTimeout. Made
the change, PTAL
If this line means 3 min default
```
maxConsecutiveIdleCount = (3 * 60 * 1000) / (idlePipeSleepTimeMillis +
partitionLevelStreamConfig
.getFetchTimeoutMillis());
```
then I'd like to keep my refactoring, make the `DEFAULT_IDLE_TIMEOUT_MILLIS`
3 mins, and remove this consecutive count code as it is quite confusing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
