richardstartin commented on PR #8746: URL: https://github.com/apache/pinot/pull/8746#issuecomment-1133550854
> Thanks for adding more test cases to ensure star-tree works as expected. In this test, currently seems there is no guarantee that the star-tree with dimension `DepDelay`, `ArrDelay` and `OriginStateName`, and function metric pair `SUM(DepDelayMinutes)` is generated, and we don't really check that the star-query utilizes the star-tree. Can we enhance the test to also check that? > Thanks for adding more test cases to ensure star-tree works as expected. In this test, currently seems there is no guarantee that the star-tree with dimension `DepDelay`, `ArrDelay` and `OriginStateName`, and function metric pair `SUM(DepDelayMinutes)` is generated, and we don't really check that the star-query utilizes the star-tree. Can we enhance the test to also check that? I was helping out with #6487 and verified that not all queries which claim to use the StarTree in this test do, it would be useful to have that metadata to help assert -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
