Jackie-Jiang commented on code in PR #8744:
URL: https://github.com/apache/pinot/pull/8744#discussion_r879856732
##########
pinot-compatibility-verifier/src/main/java/org/apache/pinot/compat/SegmentOp.java:
##########
@@ -294,7 +294,7 @@ private boolean deleteSegment() {
_segmentName = _tableName + "_" + _generationNumber;
}
- ControllerTest.sendDeleteRequest(
+ ControllerTest.getInstance().sendDeleteRequest(
Review Comment:
Revert the changes in this file
##########
pinot-controller/src/test/java/org/apache/pinot/controller/api/PinotAccessControlUserRestletResourceTest.java:
##########
@@ -88,16 +89,16 @@ public void testUpdateUserConfig()
String username = "updateTC";
String userConfigString =
_userConfigBuilder.setUsername(username).setComponentType(ComponentType.CONTROLLER)
.build().toJsonString();
- ControllerTestUtils.sendPostRequest(_createUserUrl, userConfigString);
+ ControllerTest.sendPostRequest(_createUserUrl, userConfigString);
// user creation should succeed
UserConfig userConfig = getUserConfig(username, "CONTROLLER");
Assert.assertEquals(userConfig.getRoleType().toString(),
RoleType.USER.toString());
Assert.assertTrue(BcryptUtils.checkpw("123456",
userConfig.getPassword()));
userConfig.setRole("ADMIN");
userConfig.setPassword("654321");
- JsonNode jsonResponse = JsonUtils.stringToJsonNode(ControllerTestUtils
-
.sendPutRequest(ControllerTestUtils.getControllerRequestURLBuilder()
+ JsonNode jsonResponse = JsonUtils.stringToJsonNode(TEST_INSTANCE
Review Comment:
```suggestion
JsonNode jsonResponse = JsonUtils.stringToJsonNode(ControllerTest
```
##########
pinot-compatibility-verifier/src/main/java/org/apache/pinot/compat/Utils.java:
##########
@@ -57,6 +57,6 @@ public static JsonNode postSqlQuery(String query, String
brokerBaseApiUrl)
payload.put("queryOptions", "groupByMode=sql;responseFormat=sql");
return JsonUtils.stringToJsonNode(
- ControllerTest.sendPostRequest(brokerBaseApiUrl + "/query/sql",
payload.toString()));
+ ControllerTest.getInstance().sendPostRequest(brokerBaseApiUrl +
"/query/sql", payload.toString()));
Review Comment:
Revert the changes in this file
##########
pinot-controller/src/test/java/org/apache/pinot/controller/api/PinotSchemaRestletResourceTest.java:
##########
@@ -49,8 +50,8 @@ public void testPostJson() {
+ " \"metricFieldSpecs\" : [ {\n" + " \"name\" : \"score\",\n" + "
\"dataType\" : \"FLOAT\"\n"
+ " } ]}";
try {
- final String response = ControllerTestUtils
-
.sendPostRequest(ControllerTestUtils.getControllerRequestURLBuilder().forSchemaCreate(),
schemaString);
+ final String response = TEST_INSTANCE
Review Comment:
```suggestion
final String response = ControllerTest
```
##########
pinot-controller/src/test/java/org/apache/pinot/controller/api/PinotAccessControlUserRestletResourceTest.java:
##########
@@ -113,25 +114,25 @@ public void testDeleteUser()
// Case 1: Create a CONTORLLER user and delete it directly w/o using
query param.
UserConfig controllerUserConfig =
_userConfigBuilder.setUsername("user1")
.setComponentType(ComponentType.CONTROLLER).build();
- String creationResponse = ControllerTestUtils
+ String creationResponse = TEST_INSTANCE
Review Comment:
```suggestion
String creationResponse = ControllerTest
```
##########
pinot-compatibility-verifier/src/main/java/org/apache/pinot/compat/TableOp.java:
##########
@@ -109,7 +109,7 @@ private boolean createSchema() {
Map<String, String> headers = new HashMap<String, String>() {{
put("Content-type", "application/json");
}};
- ControllerTest.sendPostRequestRaw(
+ ControllerTest.getInstance().sendPostRequestRaw(
Review Comment:
Revert the changes in this file
##########
pinot-compatibility-verifier/src/main/java/org/apache/pinot/compat/StreamOp.java:
##########
@@ -222,8 +222,8 @@ private boolean produceData() {
String timeColumn =
tableConfig.getValidationConfig().getTimeColumnName();
String schemaName = TableNameBuilder.extractRawTableName(tableName);
- String schemaString = ControllerTest.
-
sendGetRequest(ControllerRequestURLBuilder.baseUrl(ClusterDescriptor.getInstance().getControllerUrl())
+ String schemaString = ControllerTest.getInstance()
Review Comment:
Revert the changes in this file
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
