siddharthteotia commented on code in PR #8720:
URL: https://github.com/apache/pinot/pull/8720#discussion_r879897295
##########
pinot-spi/src/main/java/org/apache/pinot/spi/utils/CommonConstants.java:
##########
@@ -218,11 +225,16 @@ public static class Broker {
public static final String CONFIG_OF_BROKER_GROUPBY_TRIM_THRESHOLD =
"pinot.broker.groupby.trim.threshold";
public static final int DEFAULT_BROKER_GROUPBY_TRIM_THRESHOLD = 1_000_000;
+ // Configure the request handler type used by broker to handler inbound
query request.
+ // NOTE: the request handler type refers to the communication between
Broker and Server.
+ public static final String BROKER_REQUEST_HANDLER_TYPE_JSON_OVERRIDE_KEY =
"handler.type";
Review Comment:
(nit) Better place for this is the Request specific options under the Broker
options
See this -
https://github.com/apache/pinot/blob/master/pinot-spi/src/main/java/org/apache/pinot/spi/utils/CommonConstants.java#L246
Also, can we name it something like `"use.multistage.engine"` or something
similar
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
