Jackie-Jiang commented on PR #8758: URL: https://github.com/apache/pinot/pull/8758#issuecomment-1135212171
This solution can cause big performance impact on existing non-order-by queries if enabled. I'd suggest directly enhancing the query engine for group-by queries without order-by on aggregations. In the query executor: 1. Implicitly order-by the group-by columns not included in the order-by if the explicit order-by clause have the same value for 2 groups 2. If there is no aggregation in the order-by clause, we don't need to keep more groups than the `LIMIT`. We should make a priority queue + map solution to only keep track of the top `LIMIT` groups. This solution can always give the accurate result, but without adding too much overhead -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
