richardstartin commented on PR #8759: URL: https://github.com/apache/pinot/pull/8759#issuecomment-1135602195
> > Note that a little bit of copy and paste is necessary in the predicate evaluators to ensure that applySV can be inlined into the batch loop, which increases the line count here more than might be expected. > > Just to be sure: The reason why `applySV(int, int[], int[])` may not be inlined if it is defined in the superclass is that it calls `applySV(int)`, which is overloaded by each predicate, right? Yes, that’s the idea. It won’t show up as a problem until there are three or more predicates per data type though, so it would be easy to craft a benchmark to convince oneself erroneously that this isn’t necessary. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
