siddharthteotia commented on PR #8764: URL: https://github.com/apache/pinot/pull/8764#issuecomment-1136087220
So besides the single docId based scan evaluation which is improved in this and the previous PR https://github.com/apache/pinot/pull/8759/, one other thing that was showing up in the profile in https://github.com/apache/pinot/issues/8634 was the `vtable stub` potentially hinting at overhead associated with virtual call dispatch over 32 concrete types of `FixedBitIntReader` inside `FixedBitSVForwardIndexReaderV2`. I am guessing that this overhead will also get amortized because of the bulk access being done from next() -> matchValues -> applySV -> readDictIds -> applySV and therefore reducing the number of times the virtual dispatch is done ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
