Jackie-Jiang commented on code in PR #8766:
URL: https://github.com/apache/pinot/pull/8766#discussion_r880970866
##########
pinot-core/src/main/java/org/apache/pinot/core/query/pruner/ColumnValueSegmentPruner.java:
##########
@@ -277,7 +286,8 @@ private boolean pruneEqPredicate(IndexSegment segment,
EqPredicate eqPredicate,
// Check bloom filter
BloomFilterReader bloomFilter = dataSource.getBloomFilter();
if (bloomFilter != null) {
- if (!bloomFilter.mightContain(value.toString())) {
+ Hash128 hash = hashes.computeIfAbsent(value, Hash128::new);
Review Comment:
I don't think we can use identity map here. Notice that the value might go
through some conversion, so each time we are getting the same reference. We
should probably just use a hash map from `String` to `Hash128`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
