Jackie-Jiang commented on code in PR #8724:
URL: https://github.com/apache/pinot/pull/8724#discussion_r880987756
##########
pinot-common/src/main/java/org/apache/pinot/common/utils/DataSchema.java:
##########
@@ -466,6 +467,8 @@ private static double[] toDoubleArray(Object value) {
doubleValues[i] = longValues[i];
}
return doubleValues;
+ } else if (value instanceof DoubleArrayList) {
Review Comment:
(minor) Suggest moving this between `double[]` and `int[]` case because this
branch could be hit in normal case, other branches will only be hit when
different segments have different schema
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
