xiangfu0 commented on code in PR #8743:
URL: https://github.com/apache/pinot/pull/8743#discussion_r881074255
##########
pinot-common/src/main/java/org/apache/pinot/common/utils/config/TableConfigUtils.java:
##########
@@ -258,32 +257,26 @@ public static void
convertFromLegacyTableConfig(TableConfig tableConfig) {
IndexingConfig indexingConfig = tableConfig.getIndexingConfig();
if (streamIngestionConfig == null) {
- Map<String, String> streamConfigs = indexingConfig.getStreamConfigs();
-
// Only set the new config if the deprecated one is set.
- if (streamConfigs != null && !streamConfigs.isEmpty()) {
+ Map<String, String> streamConfigs = indexingConfig.getStreamConfigs();
+ if (MapUtils.isNotEmpty(streamConfigs)) {
streamIngestionConfig = new
StreamIngestionConfig(Collections.singletonList(streamConfigs));
}
}
if (ingestionConfig == null) {
if (batchIngestionConfig != null || streamIngestionConfig != null) {
- ingestionConfig = new IngestionConfig(batchIngestionConfig,
streamIngestionConfig, null, null, null, null);
- }
- } else {
- if (batchIngestionConfig != null) {
+ ingestionConfig = new IngestionConfig();
Review Comment:
shall we always create an empty IngestionConfig ? Does null represent
something else?
##########
pinot-spi/src/main/java/org/apache/pinot/spi/config/table/ingestion/IngestionConfig.java:
##########
@@ -33,7 +31,7 @@
public class IngestionConfig extends BaseJsonConfig {
@JsonPropertyDescription("Config related to the batch data sources")
- private BatchIngestionConfig _batchIngestionConfig;
+ public BatchIngestionConfig _batchIngestionConfig;
Review Comment:
why public?
##########
pinot-spi/src/main/java/org/apache/pinot/spi/config/table/ingestion/IngestionConfig.java:
##########
@@ -33,7 +31,7 @@
public class IngestionConfig extends BaseJsonConfig {
@JsonPropertyDescription("Config related to the batch data sources")
- private BatchIngestionConfig _batchIngestionConfig;
+ public BatchIngestionConfig _batchIngestionConfig;
Review Comment:
why public?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
