KKcorps commented on code in PR #8768:
URL: https://github.com/apache/pinot/pull/8768#discussion_r882407167
##########
pinot-core/src/main/java/org/apache/pinot/core/startree/operator/StarTreeFilterOperator.java:
##########
@@ -201,22 +197,22 @@ private BaseFilterOperator getFilterOperator() {
int numPredicateEvaluators = predicateEvaluators.size();
if (numPredicateEvaluators == 1) {
// Single predicate evaluator
- childFilterOperators
-
.add(FilterOperatorUtils.getLeafFilterOperator(predicateEvaluators.get(0),
dataSource, numDocs));
+ childFilterOperators.add(
Review Comment:
nit: unnecessary formatting
##########
pinot-broker/src/main/java/org/apache/pinot/broker/routing/segmentselector/RealtimeSegmentSelector.java:
##########
@@ -95,8 +93,8 @@ public void onAssignmentChange(IdealState idealState,
ExternalView externalView,
if (instanceStateMap.containsValue(SegmentStateModel.CONSUMING)) {
// Keep the first CONSUMING segment for each partition
LLCSegmentName llcSegmentName = new LLCSegmentName(segment);
- partitionIdToFirstConsumingLLCSegmentMap
- .compute(llcSegmentName.getPartitionGroupId(), (k,
consumingSegment) -> {
+
partitionIdToFirstConsumingLLCSegmentMap.compute(llcSegmentName.getPartitionGroupId(),
Review Comment:
nit: formatting
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
