siddharthteotia commented on code in PR #8720:
URL: https://github.com/apache/pinot/pull/8720#discussion_r882871295
##########
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/SingleConnectionBrokerRequestHandler.java:
##########
@@ -72,6 +72,7 @@ public
SingleConnectionBrokerRequestHandler(PinotConfiguration config, BrokerRou
AccessControlFactory accessControlFactory, QueryQuotaManager
queryQuotaManager, TableCache tableCache,
BrokerMetrics brokerMetrics, NettyConfig nettyConfig, TlsConfig
tlsConfig) {
super(config, routingManager, accessControlFactory, queryQuotaManager,
tableCache, brokerMetrics);
+ LOGGER.info("Starting Netty BrokerRequestHandler.");
Review Comment:
Same here. Put this under `start()`
##########
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/SingleConnectionBrokerRequestHandler.java:
##########
@@ -72,6 +72,7 @@ public
SingleConnectionBrokerRequestHandler(PinotConfiguration config, BrokerRou
AccessControlFactory accessControlFactory, QueryQuotaManager
queryQuotaManager, TableCache tableCache,
BrokerMetrics brokerMetrics, NettyConfig nettyConfig, TlsConfig
tlsConfig) {
super(config, routingManager, accessControlFactory, queryQuotaManager,
tableCache, brokerMetrics);
+ LOGGER.info("Starting Netty BrokerRequestHandler.");
Review Comment:
Same here. Put this under `start()` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
