jackjlli commented on code in PR #8784:
URL: https://github.com/apache/pinot/pull/8784#discussion_r883135816
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java:
##########
@@ -3178,6 +3181,7 @@ public String startReplaceSegments(String
tableNameWithType, List<String> segmen
String errorMsg = String.format("Failed to update the segment lineage
during startReplaceSegments. "
+ "(tableName = %s, segmentsFrom = %s, segmentsTo = %s)",
tableNameWithType, segmentsFrom, segmentsTo);
LOGGER.error(errorMsg, e);
+ _controllerMetrics.addMeteredTableValue(tableNameWithType,
ControllerMeter.NUMBER_START_REPLACE_FAILURE, 1);
Review Comment:
Can these metrics be emitted on resource level? By doing so, you don't have
to inject the controllerMetrics class into the resource manager.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
