Airliquide76 commented on code in PR #8589: URL: https://github.com/apache/pinot/pull/8589#discussion_r883455422
########## pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/purge/PurgeTaskGenerator.java: ########## @@ -0,0 +1,160 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.plugin.minion.tasks.purge; + +import com.google.common.base.Preconditions; +import java.util.ArrayList; +import java.util.Collections; +import java.util.Comparator; +import java.util.HashMap; +import java.util.List; +import java.util.Map; +import java.util.Set; +import java.util.function.Predicate; +import java.util.stream.Collectors; +import org.apache.pinot.common.data.Segment; +import org.apache.pinot.common.metadata.segment.SegmentZKMetadata; +import org.apache.pinot.controller.api.exception.UnknownTaskTypeException; +import org.apache.pinot.controller.helix.core.minion.generator.BaseTaskGenerator; +import org.apache.pinot.controller.helix.core.minion.generator.TaskGeneratorUtils; +import org.apache.pinot.core.common.MinionConstants; +import org.apache.pinot.core.minion.PinotTaskConfig; +import org.apache.pinot.spi.annotations.minion.TaskGenerator; +import org.apache.pinot.spi.config.table.TableConfig; +import org.apache.pinot.spi.config.table.TableTaskConfig; +import org.apache.pinot.spi.config.table.TableType; +import org.apache.pinot.spi.utils.TimeUtils; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + + +@TaskGenerator +public class PurgeTaskGenerator extends BaseTaskGenerator { + private static final Logger LOGGER = LoggerFactory.getLogger(PurgeTaskGenerator.class); + private static final String DEFAULT_DELTA_PERIOD = "1d"; + + @Override + public String getTaskType() { + return MinionConstants.PurgeTask.TASK_TYPE; + } + + @Override + public List<PinotTaskConfig> generateTasks(List<TableConfig> tableConfigs) { + LOGGER.info("Start generating PurgeTask"); + String taskType = MinionConstants.PurgeTask.TASK_TYPE; + List<PinotTaskConfig> pinotTaskConfigs = new ArrayList<>(); + + for (TableConfig tableConfig : tableConfigs) { + + String tableName = tableConfig.getTableName(); + if (tableConfig.getTableType() == TableType.REALTIME) { + LOGGER.info("Task type : {}, cannot be run on table of type {}", taskType, TableType.REALTIME); + continue; + } + + Map<String, String> taskConfigs; + try { + TableTaskConfig tableTaskConfig = tableConfig.getTaskConfig(); + Preconditions.checkNotNull(tableTaskConfig); + taskConfigs = tableTaskConfig.getConfigsForTaskType(MinionConstants.PurgeTask.TASK_TYPE); + Preconditions.checkNotNull(taskConfigs, "Task config shouldn't be null for Table: {}", tableName); + } catch (Exception e) { + continue; + } + String deltaTimePeriod = + taskConfigs.getOrDefault(MinionConstants.PurgeTask.DELTA_TIME_PERIOD_KEY, DEFAULT_DELTA_PERIOD); + long purgeDeltaMs = TimeUtils.convertPeriodToMillis(deltaTimePeriod); + + LOGGER.info("Start generating task configs for table: {} for task: {}", tableName, taskType); + // Get max number of tasks for this table + int tableMaxNumTasks; + String tableMaxNumTasksConfig = taskConfigs.get(MinionConstants.TABLE_MAX_NUM_TASKS_KEY); + if (tableMaxNumTasksConfig != null) { + try { + tableMaxNumTasks = Integer.parseInt(tableMaxNumTasksConfig); + } catch (Exception e) { + tableMaxNumTasks = Integer.MAX_VALUE; + LOGGER.warn("MaxNumTasks have been wrongly set for table : {}, and task {}", tableName, taskType); + } + } else { + tableMaxNumTasks = Integer.MAX_VALUE; + } + List<SegmentZKMetadata> offlineSegmentsZKMetadata = _clusterInfoAccessor.getSegmentsZKMetadata(tableName); + + Predicate<SegmentZKMetadata> alreadyPurged = segment -> segment.getCustomMap() != null; + Predicate<SegmentZKMetadata> notPurged = segment -> segment.getCustomMap() == null; + + List<SegmentZKMetadata> purgedSegmentsZKMetadata = + offlineSegmentsZKMetadata.stream().filter(alreadyPurged).collect(Collectors.toList()); + + List<SegmentZKMetadata> notpurgedSegmentsZKMetadata = + offlineSegmentsZKMetadata.stream().filter(notPurged).collect(Collectors.toList()); + + Collections.sort(purgedSegmentsZKMetadata, Comparator.comparing( + segmentZKMetadata -> segmentZKMetadata.getCustomMap() + .get(MinionConstants.PurgeTask.TASK_TYPE + MinionConstants.TASK_TIME_SUFFIX), + Comparator.nullsFirst(Comparator.naturalOrder()))); + //add already purged segment at the end + notpurgedSegmentsZKMetadata.addAll(purgedSegmentsZKMetadata); Review Comment: yes but SegmentZKMetadata should then implement Serializable. Not really aware of all the impacts ... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
