KKcorps opened a new issue, #8799: URL: https://github.com/apache/pinot/issues/8799
Currently there are three issues with `SegmentNameGenerator` classes - * The implementations need to be supplied with exact arguments instead of general segment name generator config. e.g. You need to provide `dateTimeFormatSpect, `pushType`, `excludeSequenceId` etc. but instead you can simply pass `segmentNameGeneratorConfig` to the constructor and let the implementation take care of extracting out props. * Any change to segmentName logic requires changing the implementation classes. We can rely on something like templates to generate the segment name rather than having to implement code change. * A lot of segment name generator props are duplicates in `BatchConfigProperties` as well. Addressing 1 should also help addresses this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
