KKcorps commented on code in PR #8321:
URL: https://github.com/apache/pinot/pull/8321#discussion_r884403717
##########
pinot-plugins/pinot-stream-ingestion/pinot-kafka-2.0/src/main/java/org/apache/pinot/plugin/stream/kafka20/KafkaPartitionLevelConsumer.java:
##########
@@ -57,6 +59,14 @@ public MessageBatch<byte[]> fetchMessages(long startOffset,
long endOffset, int
endOffset, timeoutMillis);
}
_consumer.seek(_topicPartition, startOffset);
Review Comment:
I guess a better way would be to just do `_consumer.seek(_topicPartition,
Max(startOffset, beginningOffset))`. Will help us avoid 2 seeks in case of
failure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
