mqliang commented on code in PR #8820:
URL: https://github.com/apache/pinot/pull/8820#discussion_r888407388
##########
pinot-server/src/main/java/org/apache/pinot/server/starter/helix/BaseServerStarter.java:
##########
@@ -346,7 +346,7 @@ private void updateInstanceConfigIfNeeded(ServerConf
serverConf) {
Map<String, String> systemResourceInfoMap = new
SystemResourceInfo().toMap();
if
(!systemResourceInfoMap.equals(znRecord.getMapField(Instance.SYSTEM_RESOURCE_INFO_KEY)))
{
Review Comment:
> It'd be good to check whether the new kv pairs from the new map equal to
the ones appeared from ZNRecord.
we already do the check:
```
if
(!systemResourceInfoMap.equals(znRecord.getMapField(Instance.SYSTEM_RESOURCE_INFO_KEY)))
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
