saurabhd336 commented on code in PR #8848:
URL: https://github.com/apache/pinot/pull/8848#discussion_r890792792
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/creator/impl/SegmentColumnarIndexCreator.java:
##########
@@ -386,30 +386,78 @@ public void indexRow(GenericRow row)
// bloom filter
BloomFilterCreator bloomFilterCreator =
_bloomFilterCreatorMap.get(columnName);
if (bloomFilterCreator != null) {
- bloomFilterCreator.add(columnValueToIndex.toString());
+ if (fieldSpec.isSingleValueField()) {
+ bloomFilterCreator.add(columnValueToIndex.toString());
+ } else {
+ Object[] values = (Object[]) columnValueToIndex;
+ for (Object value: values) {
+ bloomFilterCreator.add(value.toString());
+ }
+ }
}
// range index
CombinedInvertedIndexCreator combinedInvertedIndexCreator =
_rangeIndexFilterCreatorMap.get(columnName);
if (combinedInvertedIndexCreator != null) {
if (dictionaryCreator != null) {
Review Comment:
I was following the segment loading part, and there seems to be handling for
both single and multi value for non dictionary encoded columns.. Should be
adding this constraint in the offline path?
https://github.com/apache/pinot/blob/master/pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/loader/invertedindex/RangeIndexHandler.java#L170
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
