mayankshriv opened a new pull request, #8855:
URL: https://github.com/apache/pinot/pull/8855
The test `ConfigUtilsTest.testDefaultObfuscation` had a bug where the
configuration was not created
correctly and hence did not have any credentials. And the test asserted that
it wouldn't find any
credentials when serialized to String.
- Fixed the test to create the configuration correctly. Enhanced the test to
ensure it gets the
`credentials` key, but not the credentials themselves.
- Had to modify the toString() method for `PinotConfiguration`, as it does
not really serialize the
the configurations, it has to be first converted `toMap()` before
serialization.
Instructions:
1. The PR has to be tagged with at least one of the following labels (*):
1. `feature`
2. `bugfix`
3. `performance`
4. `ui`
5. `backward-incompat`
6. `release-notes` (**)
2. Remove these instructions before publishing the PR.
(*) Other labels to consider:
- `testing`
- `dependencies`
- `docker`
- `kubernetes`
- `observability`
- `security`
- `code-style`
- `extension-point`
- `refactor`
- `cleanup`
(**) Use `release-notes` label for scenarios like:
- New configuration options
- Deprecation of configurations
- Signature changes to public methods/interfaces
- New plugins added or old plugins removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
