walterddr commented on code in PR #8836:
URL: https://github.com/apache/pinot/pull/8836#discussion_r891819617
##########
pinot-server/src/main/java/org/apache/pinot/server/starter/helix/BaseServerStarter.java:
##########
@@ -329,6 +329,14 @@ private void updateInstanceConfigIfNeeded(ServerConf
serverConf) {
int grpcPort = serverConf.isEnableGrpcServer() ? serverConf.getGrpcPort()
: Integer.MIN_VALUE;
updated |= updatePortIfNeeded(simpleFields, Instance.GRPC_PORT_KEY,
grpcPort);
+ // Update multi-stage query engine ports
+ if (serverConf.isMultiStageServerEnabled()) {
+ updated |= updatePortIfNeeded(simpleFields,
+ Instance.MULTI_STAGE_QUERY_ENGINE_SERVICE_PORT_KEY,
serverConf.getMultiStageServicePort());
+ updated |= updatePortIfNeeded(simpleFields,
+ Instance.MULTI_STAGE_QUERY_ENGINE_MAILBOX_PORT_KEY,
serverConf.getMultiStageMailboxPort());
+ }
Review Comment:
this cannot be a seamless upgrade because the instance configuration stored
In ZK from previous version of pinot will not have these 2 configuration ports.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
