siddharthteotia commented on code in PR #8874:
URL: https://github.com/apache/pinot/pull/8874#discussion_r894761115
##########
pinot-core/src/main/java/org/apache/pinot/core/common/datatable/DataTableUtils.java:
##########
@@ -71,10 +71,12 @@ public static int computeColumnOffsets(DataSchema
dataSchema, int[] columnOffset
case LONG:
rowSizeInBytes += 8;
break;
- // TODO: fix float size (should be 4).
- // For backward compatible, DON'T CHANGE.
case FLOAT:
- rowSizeInBytes += 8;
+ if (dataTableVersion >= 4) {
Review Comment:
During upgrade broker should still be able to handle receiving FLOAT as 8
bytes since broker is upgraded first and there will be new broker, old server
for some point of time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
