Jackie-Jiang commented on code in PR #8868:
URL: https://github.com/apache/pinot/pull/8868#discussion_r894821613
##########
pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/ImmutableSegment.java:
##########
@@ -55,4 +55,13 @@ public interface ImmutableSegment extends IndexSegment {
* @return Size of the segment in bytes
*/
long getSegmentSizeBytes();
+
+ /**
+ * Get the storage tier of the immutable segment.
+ *
+ * @return storage tier, null by default.
+ */
+ default String getTier() {
Review Comment:
Annotate it as `nullable`, and suggest not adding a default implementation
here because we want all implementations to explicitly implement this
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/indexsegment/immutable/ImmutableSegmentImpl.java:
##########
@@ -117,6 +117,11 @@ public long getSegmentSizeBytes() {
return _segmentDirectory.getDiskSizeBytes();
}
+ @Override
Review Comment:
Annotate it as nullable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
