This is an automated email from the ASF dual-hosted git repository.

nehapawar pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git


The following commit(s) were added to refs/heads/master by this push:
     new 9c8a689c43 Fix getConfigOverrides in MinionQuickstart (#8858)
9c8a689c43 is described below

commit 9c8a689c431c1aa663901d4aeb40b1ce642ba098
Author: Neha Pawar <[email protected]>
AuthorDate: Sun Jun 12 08:06:38 2022 -0700

    Fix getConfigOverrides in MinionQuickstart (#8858)
    
    * Fix getConfigOverrides in MinionQuickstart
    
    * Keep super configs
---
 pinot-tools/src/main/java/org/apache/pinot/tools/AuthQuickstart.java   | 2 +-
 pinot-tools/src/main/java/org/apache/pinot/tools/HybridQuickstart.java | 2 +-
 .../main/java/org/apache/pinot/tools/RealtimeQuickStartWithMinion.java | 3 ++-
 3 files changed, 4 insertions(+), 3 deletions(-)

diff --git 
a/pinot-tools/src/main/java/org/apache/pinot/tools/AuthQuickstart.java 
b/pinot-tools/src/main/java/org/apache/pinot/tools/AuthQuickstart.java
index ff2ea7d047..2642bbbb19 100644
--- a/pinot-tools/src/main/java/org/apache/pinot/tools/AuthQuickstart.java
+++ b/pinot-tools/src/main/java/org/apache/pinot/tools/AuthQuickstart.java
@@ -41,7 +41,7 @@ public class AuthQuickstart extends Quickstart {
 
   @Override
   public Map<String, Object> getConfigOverrides() {
-    Map<String, Object> properties = new HashMap<>();
+    Map<String, Object> properties = new HashMap<>(super.getConfigOverrides());
 
     // controller
     properties.put("pinot.controller.segment.fetcher.auth.token", "Basic 
YWRtaW46dmVyeXNlY3JldA==");
diff --git 
a/pinot-tools/src/main/java/org/apache/pinot/tools/HybridQuickstart.java 
b/pinot-tools/src/main/java/org/apache/pinot/tools/HybridQuickstart.java
index a339292b58..3ef0945a75 100644
--- a/pinot-tools/src/main/java/org/apache/pinot/tools/HybridQuickstart.java
+++ b/pinot-tools/src/main/java/org/apache/pinot/tools/HybridQuickstart.java
@@ -67,7 +67,7 @@ public class HybridQuickstart extends QuickStartBase {
   }
 
   public Map<String, Object> getConfigOverrides() {
-    Map<String, Object> overrides = new HashMap<>();
+    Map<String, Object> overrides = new HashMap<>(super.getConfigOverrides());
     overrides.put("pinot.server.grpc.enable", "true");
     overrides.put("pinot.server.grpc.port", "8090");
     return overrides;
diff --git 
a/pinot-tools/src/main/java/org/apache/pinot/tools/RealtimeQuickStartWithMinion.java
 
b/pinot-tools/src/main/java/org/apache/pinot/tools/RealtimeQuickStartWithMinion.java
index 6809e659c4..60786d82a3 100644
--- 
a/pinot-tools/src/main/java/org/apache/pinot/tools/RealtimeQuickStartWithMinion.java
+++ 
b/pinot-tools/src/main/java/org/apache/pinot/tools/RealtimeQuickStartWithMinion.java
@@ -25,6 +25,7 @@ import java.net.URL;
 import java.nio.charset.StandardCharsets;
 import java.util.ArrayList;
 import java.util.Arrays;
+import java.util.HashMap;
 import java.util.List;
 import java.util.Map;
 import java.util.Properties;
@@ -63,7 +64,7 @@ public class RealtimeQuickStartWithMinion extends 
QuickStartBase {
   }
 
   public Map<String, Object> getConfigOverrides() {
-    Map<String, Object> properties = super.getConfigOverrides();
+    Map<String, Object> properties = new HashMap<>(super.getConfigOverrides());
     properties.putIfAbsent("controller.task.scheduler.enabled", true);
     return properties;
   }


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to