Jackie-Jiang commented on code in PR #8874:
URL: https://github.com/apache/pinot/pull/8874#discussion_r897046830


##########
pinot-core/src/main/java/org/apache/pinot/core/common/datatable/DataTableBuilder.java:
##########
@@ -81,6 +81,7 @@
 public class DataTableBuilder {
   public static final int VERSION_2 = 2;
   public static final int VERSION_3 = 3;
+  public static final int VERSION_4 = 4;

Review Comment:
   Ideally we should have a factory for the builders so that the logic can be 
separated. Can be addressed separately.
   
   Please update the TODOs in this class



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to