walterddr commented on code in PR #8894:
URL: https://github.com/apache/pinot/pull/8894#discussion_r899634281
##########
pinot-core/src/main/java/org/apache/pinot/core/common/datablock/BaseDataBlock.java:
##########
@@ -84,7 +84,7 @@ public abstract class BaseDataBlock implements DataTable {
protected int _numRows;
protected int _numColumns;
protected DataSchema _dataSchema;
- protected Map<String, Map<Integer, String>> _dictionaryMap;
+ protected String[] _stringDictionary;
Review Comment:
no just one dictionary. it is using the array index itself as Integer key.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]