jasperjiaguo commented on code in PR #8956:
URL: https://github.com/apache/pinot/pull/8956#discussion_r904418814
##########
pinot-controller/src/main/java/org/apache/pinot/controller/recommender/rules/io/params/RecommenderConstants.java:
##########
@@ -71,6 +71,7 @@ public static class BloomFilterRule {
public static class RangeIndexRule {
public static final double DEFAULT_THRESHOLD_MIN_PERCENT_RANGE_INDEX = 0.4;
+ public static final double DEFAULT_THRESHOLD_MIN_CARDINALITY_RANGE_INDEX =
2;
Review Comment:
Put two here for some buffer, it is a trade-off between false positive and
false negative. We will have to tune this in production (the parameters here
are all tunable).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
