Jackie-Jiang commented on code in PR #8884:
URL: https://github.com/apache/pinot/pull/8884#discussion_r905529608
##########
pinot-common/src/main/java/org/apache/pinot/common/utils/DataTable.java:
##########
@@ -113,6 +113,9 @@ enum MetadataKey {
SYSTEM_ACTIVITIES_CPU_TIME_NS("systemActivitiesCpuTimeNs",
MetadataValueType.LONG),
RESPONSE_SER_CPU_TIME_NS("responseSerializationCpuTimeNs",
MetadataValueType.LONG),
NUM_SEGMENTS_PRUNED_BY_SERVER("numSegmentsPrunedByServer",
MetadataValueType.INT),
+ NUM_SEGMENTS_PRUNED_INVALID("numSegmentsPrunedByInvalid",
MetadataValueType.INT),
Review Comment:
(MAJOR) Please append the new keys to the end. See the javadoc for this enum.
We should associate an id to each key instead of relying on the ordinal of
the enum. That is out of the scope of this PR, and we need a newer version data
table so that the change is backward compatible
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
