jackjlli commented on code in PR #8959:
URL: https://github.com/apache/pinot/pull/8959#discussion_r907809747
##########
pinot-common/src/main/java/org/apache/pinot/common/minion/RealtimeToOfflineSegmentsTaskMetadata.java:
##########
@@ -26,7 +26,7 @@
* The <code>watermarkMs</code> denotes the time (exclusive) upto which tasks
have been executed.
*
* This gets serialized and stored in zookeeper under the path
- * MINION_TASK_METADATA/RealtimeToOfflineSegmentsTask/tableNameWithType
+ * MINION_TASK_METADATA/tableNameWithType/RealtimeToOfflineSegmentsTask
Review Comment:
`MINION_TASK_METADATA/t${ableNameWithType}/RealtimeToOfflineSegmentsTask`
##########
pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/realtimetoofflinesegments/RealtimeToOfflineSegmentsTaskGenerator.java:
##########
@@ -57,7 +57,7 @@
*
* Steps:
* - The watermarkMs is read from the {@link
RealtimeToOfflineSegmentsTaskMetadata} ZNode
- * found at
MINION_TASK_METADATA/RealtimeToOfflineSegmentsTask/tableNameWithType
+ * found at
MINION_TASK_METADATA/tableNameWithType/RealtimeToOfflineSegmentsTask
Review Comment:
Make it consistent as the other comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
