somandal commented on code in PR #8953:
URL: https://github.com/apache/pinot/pull/8953#discussion_r909062567
##########
pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/index/mutable/MutableForwardIndex.java:
##########
@@ -92,11 +92,26 @@ default int getDictIdMV(int docId, int[] dictIdBuffer) {
throw new UnsupportedOperationException();
}
+ /**
+ * Reads the dictionary ids for a multi-value column at the given document
id into a buffer and returns the buffer.
+ *
+ * @param docId Document id
+ * @return A buffer containing the multi-value entries
+ */
+ default int[] getDictIdMV(int docId) {
Review Comment:
So I didn't see a need to change the setDictIdMV() API as it already takes
an array of dictIDs and doesn't need to return anything:
```
default void setDictIdMV(int docId, int[] dictIds) {
throw new UnsupportedOperationException();
}
```
The above is implemented by only `FixedByteMVMutableForwardIndex` today.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
