walterddr commented on code in PR #8985:
URL: https://github.com/apache/pinot/pull/8985#discussion_r910192500
##########
pinot-common/src/main/proto/plan.proto:
##########
@@ -43,7 +43,9 @@ message StageNode {
int32 stageId = 1;
string nodeName = 2;
repeated StageNode inputs = 3;
- ObjectField objectField = 4;
+ repeated string columnNames = 4;
+ repeated string columnDataTypes = 5;
Review Comment:
i incline to make columnDataTypes ordinal enabled enum (to store as integer)
instead of storing string here. but not sure if this could cause some
backward-incompatible changes to DataSchema.ColumnDataType.
Please share your feedback
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
