mcvsubbu commented on code in PR #8986:
URL: https://github.com/apache/pinot/pull/8986#discussion_r918218555
##########
pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/PauseResumeConsumptionIntegrationTest.java:
##########
@@ -107,9 +107,8 @@ private void verifyResume(int numRecordsInTable) throws
Exception {
}
private void verify(boolean pause, int expectedNumRecordsInTable) throws
Exception {
- for (int i = 0; i < 30; i++) {
- PinotLLCRealtimeSegmentManager.PauseStatus pauseStatus =
- getControllerRequestClient().getPauseStatus(getTableName());
+ for (int i = 0; i < 60; i++) {
Review Comment:
can we declare 30/60/anytning as a final int since it is used in more than
one place (and they need to be consistent)? thanks
##########
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotRealtimeTableResource.java:
##########
@@ -109,11 +109,11 @@ public Response getConsumptionStatus(
private void validate(String tableNameWithType) {
IdealState idealState =
_pinotHelixResourceManager.getTableIdealState(tableNameWithType);
if (idealState == null) {
- throw new ControllerApplicationException(LOGGER, "Ideal State is null
for table " + tableNameWithType,
+ throw new ControllerApplicationException(LOGGER, String.format("Table %s
not found!", tableNameWithType),
Response.Status.NOT_FOUND);
}
if (!idealState.isEnabled()) {
- throw new ControllerApplicationException(LOGGER, "Ideal State is
disabled for table" + tableNameWithType,
+ throw new ControllerApplicationException(LOGGER, "Ideal State is
disabled for table " + tableNameWithType,
Review Comment:
```suggestion
throw new ControllerApplicationException(LOGGER, "Disabled table: " +
tableNameWithType,
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
