siddharthteotia commented on code in PR #8989:
URL: https://github.com/apache/pinot/pull/8989#discussion_r919586071
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java:
##########
@@ -1688,13 +1690,22 @@ private void assignInstances(TableConfig tableConfig,
boolean override) {
}
}
+ boolean isTableInGroup = TableConfigUtils.isTableInGroup(tableConfig);
Review Comment:
Furthermore
**Creating a new TableGroup out of N existing tables**
Option 1 -
- Create TableGroup and assign instances so InstancePartitions for the
group are computed and persisted
- Trigger rebalance on each of the N tables with reassignInstances set to
true
- The rebalance code will call the instance assignment driver and it should
return the existing InstancePartitions for the group.
- Segments are then assigned based on the returned InstancePartitions
Option 2 -
- Create TableGroup but don't do instance assignment.
- Trigger rebalance on each of the N tables with reassignInstances set to
true.
- The rebalance code will call the instance assignment driver and it should
detect that InstancePartitions don't exit for the group, so it assigns instance
which are then used for segment assignment.
It would be good to get clarity (and add brief details to code comments/docs
as well) on how such scenarios are handled.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
