gortiz commented on code in PR #8981:
URL: https://github.com/apache/pinot/pull/8981#discussion_r921132268
##########
pinot-controller/src/test/java/org/apache/pinot/controller/helix/ControllerTest.java:
##########
@@ -128,6 +133,11 @@ public class ControllerTest {
protected ZkHelixPropertyStore<ZNRecord> _propertyStore;
private ZkStarter.ZookeeperInstance _zookeeperInstance;
+ private final Logger _logger;
+
+ public ControllerTest() {
+ _logger = LoggerFactory.getLogger(this.getClass());
Review Comment:
It can be, but it would be worse. `ControllerTest` is extended by several
tests. Therefore by doing it like this when a subclass logs something, the
logger name will be the name of the actual class instead of `ControllerTest`.
That can be used to either fine grain filter out logs from tests we don't care
about but also it is useful when the logs are read.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
