saurabhd336 commented on code in PR #9058:
URL: https://github.com/apache/pinot/pull/9058#discussion_r921925802
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/minion/PinotTaskManager.java:
##########
@@ -517,7 +526,34 @@ private synchronized Map<String, String>
scheduleTasks(List<String> tableNamesWi
private String scheduleTask(PinotTaskGenerator taskGenerator,
List<TableConfig> enabledTableConfigs,
boolean isLeader) {
LOGGER.info("Trying to schedule task type: {}, isLeader: {}",
taskGenerator.getTaskType(), isLeader);
- List<PinotTaskConfig> pinotTaskConfigs =
taskGenerator.generateTasks(enabledTableConfigs);
+ List<PinotTaskConfig> pinotTaskConfigs;
+ try {
+ pinotTaskConfigs = taskGenerator.generateTasks(enabledTableConfigs);
+ for (TableConfig tableConfig : enabledTableConfigs) {
+ try {
+
_taskManagerStatusCache.saveTaskGeneratorInfo(tableConfig.getTableName(),
taskGenerator.getTaskType(),
+ taskGeneratorMostRecentRunInfo ->
taskGeneratorMostRecentRunInfo.addSuccessRunTs(
+ System.currentTimeMillis()));
+ } catch (Exception exception) {
+ LOGGER.warn("Failed to save task generator success timestamp to ZK",
exception);
+ }
+ }
+ } catch (Exception e) {
+ for (TableConfig tableConfig : enabledTableConfigs) {
+ try {
+ StringWriter errors = new StringWriter();
Review Comment:
Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
